Revert "fix: check UIDNEXT with a STATUS command before going IDLE" #5045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
approved these changes
Nov 24, 2023
This reverts commit 2e50abe. STATUS is broken on mail.163.com. It returns `STATUS "INBOX" ()` reply when `STATUS "INBOX" (UIDNEXT)` is requested.
link2xt
force-pushed
the
link2xt/revert-status
branch
from
3f3564a to
570450c
Compare
Collaborator
Author
|
Draft because I also need to revert 7b83bdd EDIT: actually no, this one does not need a revert, it only uses STATUS as a fallback for broken SELECT which is exactly the WinMail case. |
Collaborator
Author
|
We have annoying test timeouts again with this PR. |
This was referenced Nov 24, 2023
IMAP client hangs in IMAP IDLE if
SELECT consumed EXISTS response notifying about new messages
#4926
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2e50abe.
STATUS is broken on mail.163.com.
It returns
STATUS "INBOX" ()replywhen
STATUS "INBOX" (UIDNEXT)is requested.Fixes #5043
Fixes #5044