fix(imap): always advance expected UIDNEXT to avoid skipping IDLE in a loop #4936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/strict-uidnext
branch
3 times, most recently
from
4cee551 to
83ebc40
Compare
iequidoo
approved these changes
Nov 6, 2023
src/imap.rs
Outdated
| // | ||
| // In particular, Winmail Pro Mail Server 5.1.0616 | ||
| // never returns UIDNEXT in SELECT response, | ||
| // but responds to "SELECT INBOX (UIDNEXT)" command. |
Collaborator
There was a problem hiding this comment.
"STATUS INBOX (UIDNEXT)"?
…a loop Ensure the client does not busy loop skipping IDLE if UIDNEXT of the mailbox is higher than the last seen UID plus 1, e.g. if the message with UID=UIDNEXT-1 was deleted before we fetched it. We do not fallback to UIDNEXT=1 anymore if the STATUS command cannot determine UIDNEXT. There are no known IMAP servers with broken STATUS so far. This allows to guarantee that select_with_uidvalidity() sets UIDNEXT for the mailbox and use it in fetch_new_messages() to ensure that UIDNEXT always advances even when there are no messages to fetch.
link2xt
force-pushed
the
link2xt/strict-uidnext
branch
from
83ebc40 to
d8e5279
Compare
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the client does not busy loop
skipping IDLE if UIDNEXT of the mailbox is higher than the last seen UID plus 1, e.g. if the message
with UID=UIDNEXT-1 was deleted before we fetched it.
We do not fallback to UIDNEXT=1 anymore
if the STATUS command cannot determine UIDNEXT.
There are no known IMAP servers with broken STATUS so far. This allows to guarantee that select_with_uidvalidity() sets UIDNEXT for the mailbox and use it in fetch_new_messages() to ensure that UIDNEXT always advances even
when there are no messages to fetch.
Fixes #4935