fix: check UIDNEXT with a STATUS command before going IDLE #4927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents accidentally going IDLE when the last new message has arrived while the folder was closed. For example, this happened in some tests: 1. INBOX is selected to fetch, move and delete messages. 2. One of the messages is deleted. 3. INBOX is closed to expunge the message. 4. A new message arrives. 5. INBOX is selected with (CONDSTORE) to sync flags. 6. Delta Chat goes into IDLE without downloading the new message. To determine that a new message has arrived we need to notice that UIDNEXT has advanced when selecting the folder. However, some servers such as Winmail Pro Mail Server 5.1.0616 do not return UIDNEXT in response to SELECT command. To avoid interdependencies with the code SELECTing the folder and having to implement STATUS fallback after each SELECT even when we may not want to go IDLE due to interrupt or unsolicited EXISTS, we simply call STATUS unconditionally before IDLE.
link2xt
force-pushed
the
link2xt/check-uid-next-before-idle
branch
from
5913bc0 to
1e2d406
Compare
link2xt
commented
Nov 5, 2023
| return Ok((self, info)); | ||
| } | ||
|
|
||
| if let Some(folder) = watch_folder.as_ref() { |
Collaborator
Author
There was a problem hiding this comment.
I don't like that idle allows watch_folder to be None, but decided not to refactor in this PR.
Collaborator
Author
|
At least all the tests passed on a first try. |
iequidoo
approved these changes
Nov 5, 2023
hpk42
approved these changes
Nov 5, 2023
Contributor
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
sounds like a good approach to try, thanks for investigating the rabbit holes!
This was referenced Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents accidentally going IDLE
when the last new message has arrived
while the folder was closed.
For example, this happened in some tests:
To determine that a new message has arrived
we need to notice that UIDNEXT has advanced when selecting the folder. However, some servers such as Winmail Pro Mail Server 5.1.0616 do not return UIDNEXT in response to SELECT command.
To avoid interdependencies with the code
SELECTing the folder and having to implement
STATUS fallback after each SELECT even when we
may not want to go IDLE due to interrupt or unsolicited EXISTS, we simply call STATUS unconditionally before IDLE.
Fixes #4926