Skip to content

Revert feature to disable plugins by TS #11422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2023
Merged

Revert feature to disable plugins by TS #11422

merged 1 commit into from
Jul 26, 2023

Conversation

stockiNail
Copy link
Contributor

Fix #11420

Revert PR #11403

@stockiNail stockiNail mentioned this pull request Jul 26, 2023
Closed
@stockiNail stockiNail mentioned this pull request Jul 26, 2023
Closed
LeeLenaleee
LeeLenaleee reviewed Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also bump to 4.3.2 direct

@LeeLenaleee LeeLenaleee added this to the Version 4.3.2 milestone Jul 26, 2023
LeeLenaleee
LeeLenaleee approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved since you are short on time, I will create a bump after this mr

@etimberg etimberg merged commit bda2ae7 into chartjs:master Jul 26, 2023
@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label Jul 26, 2023
@stockiNail stockiNail mentioned this pull request Jul 31, 2023
Closed
@raymondhtet raymondhtet mentioned this pull request May 29, 2024
Closed
@wanissr wanissr mentioned this pull request Jun 22, 2024
Open
@bwilliford bwilliford mentioned this pull request Jun 26, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Jul 5, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Jul 14, 2024
Closed
@faragashraf faragashraf mentioned this pull request Jul 18, 2024
Open
This was referenced Sep 7, 2024
Open
Open
@mytamDo mytamDo mentioned this pull request Sep 16, 2024
Open
@karencapiiro karencapiiro mentioned this pull request Sep 17, 2024
Open
@scottwad scottwad mentioned this pull request Sep 24, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 24, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Sep 25, 2024
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 27, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees

No one assigned

Labels

type: types Typescript type changes

Projects

None yet

Milestone

Version 4.3.2

Development

Successfully merging this pull request may close these issues.

Moving from 4.3.0 to 4.3.1 break most of my already existing code due to types

3 participants

@stockiNail @LeeLenaleee @etimberg