Skip to content

Export explicitly the plugin options definition which is augmented by plugins implementation #11309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

Export explicitly the plugin options definition which is augmented by plugins implementation #11309

merged 1 commit into from
May 25, 2023

Conversation

@stockiNail
Copy link
Contributor

Fix #11288

The following table is showing the augmented definitions, performed by plugins in chartjs org (in addition to PluginOptionsByType) which are fixed by this PR:

Plugin Augmented Definitions
annotation ElementOptionsByType
datalabels ChartDatasetProperties
deferred -
zoom UpdateModeEnum

This PR is also reverting PR #11244

@stockiNail stockiNail mentioned this pull request May 24, 2023
Closed
@etimberg etimberg added this to the Version 4.3.1 milestone May 25, 2023
@etimberg etimberg merged commit abbd5a7 into chartjs:master May 25, 2023
@stockiNail stockiNail mentioned this pull request May 25, 2023
Closed
@stockiNail stockiNail deleted the fixTSdefExport branch May 25, 2023 18:10
@stockiNail stockiNail mentioned this pull request May 25, 2023
Merged
@LeeLenaleee LeeLenaleee added the type: types Typescript type changes label May 31, 2023
@stockiNail stockiNail mentioned this pull request Jul 24, 2023
Open
@raymondhtet raymondhtet mentioned this pull request May 29, 2024
Closed
@wanissr wanissr mentioned this pull request Jun 22, 2024
Open
@bwilliford bwilliford mentioned this pull request Jun 26, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Jul 5, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Jul 14, 2024
Closed
@faragashraf faragashraf mentioned this pull request Jul 18, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 16, 2024
Open
@karencapiiro karencapiiro mentioned this pull request Sep 17, 2024
Open
@scottwad scottwad mentioned this pull request Sep 24, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 24, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Sep 25, 2024
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees

No one assigned

Labels

type: types Typescript type changes

Projects

None yet

Milestone

Version 4.3.1

Development

Successfully merging this pull request may close these issues.

Issues importing plugins and TS module augmentation

3 participants

@stockiNail @etimberg @LeeLenaleee