Internal: Update session course permissions and visibility indicators - refs BT#21604 #5698
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| $return .= $moveIcon; | ||
| $return .= ' </a>'; | ||
| $return .= Display::getMdiIcon('poll', 'ch-tool-icon', null, 16, get_lang('Survey')); | ||
| $return .= '<a class="moved link_with_id" data-id="'.$survey['iid'].'" data_type="'.TOOL_SURVEY.'" title="'.$surveyTitle.'" href="'.api_get_self().'?'.api_get_cidreq().'&action=add_item&type='.TOOL_SURVEY.'&survey_id='.$survey['iid'].'&lp_id='.$this->lp_id.'" style="vertical-align:middle">'.$surveyTitle.'</a>'; |
There was a problem hiding this comment.
Variable "lp_id" is not in valid camel caps format
| @@ -100,25 +100,16 @@ public static function delete_all_survey_invitations_by_user($user_id) | |||
| * @return array | |||
| * @assert ('') === false | |||
| */ | |||
| public static function get_surveys($course_code, $session_id = 0) | |||
| public static function get_surveys($courseCode, int $sessionId = 0) | |||
There was a problem hiding this comment.
Method name "SurveyManager::get_surveys" is not in camel caps format
| @@ -2963,7 +2963,7 @@ public static function checkHideEditionToolsByCode($surveyCode) | |||
| * | |||
| * @version January 2007 | |||
| */ | |||
| public static function modify_filter($survey_id, $drh = false) | |||
| public static function modify_filter($survey_id, $url_params, $row) | |||
There was a problem hiding this comment.
Method name "SurveyUtil::modify_filter" is not in camel caps format
| @@ -2963,7 +2963,7 @@ | |||
| * | |||
| * @version January 2007 | |||
| */ | |||
| public static function modify_filter($survey_id, $drh = false) | |||
| public static function modify_filter($survey_id, $url_params, $row) | |||
There was a problem hiding this comment.
Variable "survey_id" is not in valid camel caps format
| @@ -2963,7 +2963,7 @@ | |||
| * | |||
| * @version January 2007 | |||
| */ | |||
| public static function modify_filter($survey_id, $drh = false) | |||
| public static function modify_filter($survey_id, $url_params, $row) | |||
There was a problem hiding this comment.
Variable "url_params" is not in valid camel caps format
…f items by roles - refs BT#21604
| $isDrh = false | ||
| ) { | ||
| int $from, | ||
| int $number_of_items, |
There was a problem hiding this comment.
Variable "number_of_items" is not in valid camel caps format
| // Survey id | ||
| $array[10] = $surveyId; | ||
|
|
||
| private static function prepare_survey_array($survey, $efv, $mandatoryAllowed, $isDrh, $canEdit = true) { |
There was a problem hiding this comment.
Method name "SurveyUtil::prepare_survey_array" is not in camel caps format
| // Survey id | ||
| $array[10] = $surveyId; | ||
|
|
||
| private static function prepare_survey_array($survey, $efv, $mandatoryAllowed, $isDrh, $canEdit = true) { |
There was a problem hiding this comment.
Opening brace should be on a new line
| } | ||
|
|
||
| $array[7] = Display::url( | ||
| $survey->getAnswered(), |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 12 spaces but found 16
| } | ||
|
|
||
| $array[7] = Display::url( | ||
| $survey->getAnswered(), |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 12 spaces but found 16
|
Code Climate has analyzed commit 6e410c7 and detected 54 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.