Course: Filter courses by access URL if multiple URLs enabled #5694
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5694 +/- ##
============================================
- Coverage 38.54% 38.53% -0.02%
- Complexity 11182 11185 +3
============================================
Files 886 886
Lines 46177 46195 +18
============================================
+ Hits 17799 17800 +1
- Misses 28378 28395 +17 ☔ View full report in Codecov by Sentry. |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| // use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryItemExtensionInterface; | ||
|
|
||
| final class CourseRelUserExtension implements QueryCollectionExtensionInterface // , QueryItemExtensionInterface | ||
| final class CourseRelUserExtension implements QueryCollectionExtensionInterface |
There was a problem hiding this comment.
Missing class doc comment
| { | ||
| public function __construct( | ||
| private readonly Security $security | ||
| private readonly Security $security, |
There was a problem hiding this comment.
Line indented incorrectly; expected 4 spaces, found 8
| { | ||
| public function __construct( | ||
| private readonly Security $security | ||
| private readonly Security $security, | ||
| private readonly AccessUrlHelper $accessUrlHelper |
There was a problem hiding this comment.
Line indented incorrectly; expected 4 spaces, found 8
| ) | ||
| ->andWhere('url_rel.url = :access_url_id') | ||
| ->setParameter('access_url_id', $accessUrl->getId()); | ||
| } else { |
There was a problem hiding this comment.
The method applyToCollection uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
Code Climate has analyzed commit ea18bb5 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.