Skip to content

feat: support @import of modules in Objective-C code #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Feb 23, 2023
Merged

feat: support @import of modules in Objective-C code #238

merged 40 commits into from
Feb 23, 2023

Conversation

cgrindel
Copy link
Owner

@cgrindel cgrindel commented Feb 23, 2023 •
edited
Loading

  • Fix the generation logic for Apple built-in frameworks to retrieve the values from the correct directories.
  • For Objective-C code, look for the import of Apple built-in frameworks and conditionally add them to the sdk_frameworks option in objc_library.
  • Generate modulemap for Swift targets @import'd by Objective-C.
  • Update module-to-Bazel label resolution to include modulemap targets when necessary.
  • Update Firebase example to use 10.5.0.
  • Enable the appdistribution example in the Firebase example.

Closes #208.
Closes #231.

@cgrindel
Add pkginfo_targets.modulemap_label_name and
7e25437 
pkginfo_targets.is_modulemap_label.
@cgrindel
Update swiftpkg_build_files to create generate_modulemap declarations.
ff8c371
@cgrindel
Update unit test to exercise Objc dependnecy
567994e
@cgrindel
Enable ios_application and ios_unit_test
693a018
@cgrindel
Comment out the header generation
42fef82
@cgrindel
Upgrade firebase to 10.x
2a9ea6b
@cgrindel
Add PrintVersionObjc binary
721c9dc
@cgrindel
Create FooSwiftVersionInfo in PrintVersionObjc.
ac4083a
@cgrindel
Better print to stdout
566c16f
@cgrindel
Add example of Objc @import Swift module.
e1a8292
@cgrindel
Add check for no header files
2ba8b74
@cgrindel
Add initial swift_files files.
fa9fa9d
@cgrindel
Creating generate_modulemap declaration for Swift with @objc.
38fd481
@cgrindel
Rename pkginfo_target_deps.bazel_label_strs to bzl_select_list.
1e99340
@cgrindel
Resolve based on depender module.
006961e
@cgrindel
Make GoogleService-Info.plist available.
1e9d085
@cgrindel
Add HACK to confirm that we need to detect SDK frameworks used by
2f5459f 
objc_library targets.
@cgrindel
Change generate_builtin_frameworks to take a --go_output option.
991fd0b
@cgrindel
Generate Starlark source file with builtins.
ddc5e74
@cgrindel
Initial objc_files.
76287bb
@cgrindel
Fix format of generated builtins for Starlark.
b3d0ac9
@cgrindel
Update .bazelrc
63dae83
@cgrindel
Fix issues with apple_builtin_frameworks
5a34693
@cgrindel
Fix generate_builtin_frameworks and tests
280b4de
@cgrindel
Added #import tests
122f4a1
@cgrindel
Add @import tests
82498a3
@cgrindel
Fix #import parse ranges
70e0489
@cgrindel
Clean up
beed166
@cgrindel
Add tests for collect_builtin_frameworks
00f7cd8
@cgrindel
Switch to root_path/pkg_path
67e4dce
@cgrindel cgrindel self-assigned this Feb 23, 2023
@cgrindel cgrindel merged commit d3f4765 into main Feb 23, 2023
@cgrindel cgrindel deleted the gh208_use_gen_modulemap_new branch February 23, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firebase iOS SDK version 10+ fails to compile The @import of Objective-C modules in Objective-C does not work.
1 participant
@cgrindel