Skip to content

fix: railtie to use correct load hook #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix: railtie to use correct load hook #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eca03d
chore: fix file typo
bf4 Jan 24, 2024
753ffdf
fix: railtie to use correct load hook
bf4 Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/jsonapi/resources/railtie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,15 @@ class Railtie < ::Rails::Railtie
load 'tasks/check_upgrade.rake'
end


initializer "jsonapi_resources.testing", after: :initialize do
next unless Rails.env.test?
# https://guides.rubyonrails.org/v6.0/engines.html#available-hooks
ActiveSupport.on_load(:action_dispatch_integration_test) do
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgebhardt this should have used this load hook

# Make response.parsed_body work
ActionDispatch::IntegrationTest.register_encoder :api_json,
::ActionDispatch::IntegrationTest.register_encoder :api_json,
param_encoder: ->(params) {
params
},
response_parser: ->(body) {
JSONAPI::MimeTypes.parser.call(body)
::JSONAPI::MimeTypes.parser.call(body)
}
end
end
Expand Down
0 ...ctive_relation_resource_retrieval_test.rb → ...ctive_relation_resource_retrieval_test.rb
View file
Open in desktop
File renamed without changes.