Skip to content

Conversation

SingleShot
Copy link

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

I was unable to get the bug template to run and could not find instructions on how to do so.

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt
Copy link
Member

Thanks @SingleShot! What version of JR are you using. Right now we have multiple versions of the gem backed by different branches. The master branch is currently being used for development of the new v0.11 branch, though the current beta of that is on the v0-11-dev branch which will eventually merge to master.

I can take this change to the version you are using and get a release out for you.

@SingleShot
Copy link
Author

Hi. I tried integrating both 0.10.7 and master to the same effect. I'm happy to work with the 11 beta.

@@ -9,7 +9,7 @@
require 'jsonapi/cached_response_fragment'
require 'jsonapi/response_document'
require 'jsonapi/acts_as_resource_controller'
if Rails::VERSION::MAJOR >= 6
if ::Rails::VERSION::MAJOR >= 6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this issue come up in response to an experience failure? This specific changes and others in the PR shouldn't be needed, I wouldn't think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought my issue was linked here but I'm not finding it. Here it is. Basically there is a namespace clash when using this project and a different JSON:API project together.

@lgebhardt
Copy link
Member

I added this in #1421 and it will go into the master branch when we merge in the v0.11 dev branch

@lgebhardt lgebhardt closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants