Add creation handler (WIP) #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts and fixes 2 when merging 14cef07 into 3163d6c - view on LGTM.com new alerts:
fixed alerts:
|
gautamp8
force-pushed
the
kopf-creation-handler
branch
from
14cef07 to
5565fa8
Compare
|
This pull request introduces 2 alerts and fixes 2 when merging 5565fa8 into 3163d6c - view on LGTM.com new alerts:
fixed alerts:
|
auvipy
requested changes
Mar 27, 2021
| import constants | ||
| from math import ceil | ||
| from collections import namedtuple | ||
| import requests |
There was a problem hiding this comment.
you can try httpx and see if any side effect
There was a problem hiding this comment.
Yes, actually, it's the old code dependency that I wrote for the prototype. I'll remove it in the next PR. It is being used to poll flower API to fetch queue length. Autoscaling implementation will change entirely.
| from models.celery_custom_resource import CeleryCustomResource | ||
|
|
||
|
|
||
| class FlowerDeploymentGenerator(object): |
There was a problem hiding this comment.
explicit inheritance from the object is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes -
TODOs:
Dependent changes -
This PR to be merged only after #15 is merged.
Upcoming changes: