Make Program expose the Expression #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program, at least today, appears to purely be a thin convenience wrapper around IdedExpr (Expression) - everything it can do, you can do yourself.
I have a use case that benefits from inspecting the AST (in short, memoizing that certain expressions can never evaluate certain ways - think basically partial evaluation, given these particular values, but with everything else unknown).
Now, obviously I can do without this; it just requires basically including my own version of Program in my program.
But given that everything Program exposes is already public - and therefore, anything that changes this particular field would be a semver change anyway - I don't see a great reason not to allow getting a const reference to the contained Expression. If this later changes, that's ok, it'll be no more breaking that if folks used Expression directly.