Skip to content

update variable names and update to TLS1.2 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update variable names and update to TLS1.2 #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b1b5f3
update variable names
Jan 28, 2020
e92a662
fix for tls 1.2
Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ the current license agreement for [Oracle Database Express Edition][].
1. Add your Oracle username and password to your build [environment variables][],
either as hidden repository settings or encrypted variables:

| Variable Name | Value |
| --------------------- | ------------- |
| `ORACLE_LOGIN_userid` | your username |
| `ORACLE_LOGIN_pass` | your password |
| Variable Name | Value |
| -------------------------- | ------------- |
| `ORACLE_LOGIN_ssousername` | your username |
| `ORACLE_LOGIN_password` | your password |

2. Add the version information to your build environment variables:

Expand Down
2 changes: 1 addition & 1 deletion download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if (credentials.length <= 0) {
process.exit(1);
}

Phantom.createAsync({ parameters: { 'ssl-protocol': 'tlsv1' } }).then(function (browser) {
Phantom.createAsync({ parameters: { 'ssl-protocol': 'tlsv1.2' } }).then(function (browser) {
browser = Promise.promisifyAll(browser, { suffix: 'Promise' });
browser.addCookie({'name': 'oraclelicense', 'value': "accept-" + env['ORACLE_COOKIE'] + "-cookie", 'domain': '.oracle.com' });

Expand Down