Skip to content

Conversation

julian-perge
Copy link
Contributor

@julian-perge julian-perge commented Apr 29, 2025

Description

The fleeting plugin installation method depends on the version of the Runner used and can be automated starting with version 16.11 of the Runner. See https://docs.gitlab.com/runner/fleet_scaling/fleeting/#install-a-fleeting-plugin

Related to #1260

Copy link
Contributor

Hey @julian-perge! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@julian-perge julian-perge changed the title Variable for determining which fleeting plugin to use feat: Variable for determining which fleeting plugin to use Apr 30, 2025
Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick fix needed. Looks good to me.

@kayman-mk kayman-mk changed the title feat: Variable for determining which fleeting plugin to use fix: choose correct installation method for fleeting plugin May 8, 2025
@kayman-mk kayman-mk changed the title fix: choose correct installation method for fleeting plugin chore: choose correct installation method for fleeting plugin May 8, 2025
@julian-perge julian-perge force-pushed the jperge-update-fleeting-plugin-logic branch from 58f0115 to e4ae0d7 Compare May 15, 2025 20:23
…gic' into jperge-update-fleeting-plugin-logic
@julian-perge julian-perge requested a review from kayman-mk May 17, 2025 18:21
Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this.

@kayman-mk kayman-mk merged commit f6c9547 into cattle-ops:main May 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants