case_sparql_select: Add JSON output mode #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is code-motion to give function names to chunks of `case_sparql_select:main`. Some upcoming patch series are going to add features that, when taken together, introduce non-trivial parameter-value cross-dependencies. Moving functionality to functions enables combinatoric testing in a `pytest` space, rather than resorting to copying, pasting, and tweaking many Makefile lines. A future patch series will add the `pytest` script. Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
This was referenced Dec 7, 2022
kchason
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested by a community member.
This patch series adds JSON output using the
to_jsonmethod provided by Pandas. This is keeping with the pattern of the other output mode functions already used incase_sparql_select(to_html,to_markdown, andto_csv).JSON output entails some configuration needs:
pandashas several options available in itsorientparameter forto_json(). This is now exposed to the command line with--json-orient.indentparameter affects JSON formatting handled elsewhere incase-utils's tests with Python's built-inpython3 -m json.tool. Theindentoption is now exposed to the command line with--json-indent.to_json()parameterdate_formatoffers two options,epoch(milliseconds) oriso(ISO-8601 string, as withxsd:dateTime). The default value chosen varies depending on theorientparameter toto_json. To relieve the user of needing side-effect knowledge, and to maintain timestamp management through the RDF pipeline, onlyisois passed bycase_sparql_select.This should be merged after #90 is merged, as it is built on the patch in 90.