Skip to content

Conversation

@ajnelson-nist
Copy link
Member

References:

  • [AC-139] FAQ question - Does CASE require hex data be entered
    uppercase or lowercase?

Signed-off-by: Alex Nelson [email protected]

References:
* [AC-139] FAQ question - Does CASE require hex data be entered
  uppercase or lowercase?

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Copy link
Member Author

@asovern-mitre , this branch is ready for your review in support of a website FAQ item, and potentially a data-policy change proposal for UCO.

  • As a style matter, is it OK with you for these tests to use the xfail design? See e.g. lines 1460 and 1462.
  • Does this hexbinary test also need to add some explicit items about testing JSON as not-JSON-LD?

@asovern-mitre
Copy link

@asovern-mitre , this branch is ready for your review in support of a website FAQ item, and potentially a data-policy change proposal for UCO.

* As a style matter, is it OK with you for these tests to use the xfail design?  See e.g. lines [1460](https://github.com/casework/CASE-Utilities-Python/pull/4/checks?check_run_id=2546928748#step:6:1460) and [1462](https://github.com/casework/CASE-Utilities-Python/pull/4/checks?check_run_id=2546928748#step:6:1462).

* Does this hexbinary test also need to add some explicit items about testing JSON as not-JSON-LD?

Styling looks fine to to me, as for the explicit testing in JSON vs not-JSON-LD, I don't think we need to do that at this time. The content in the PR seems good for now.

@asovern-mitre asovern-mitre merged commit f530add into develop May 10, 2021
@asovern-mitre asovern-mitre deleted the AC-139 branch May 10, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants