Use local_uuid, not demo_uuid #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A shortcoming in the documentation for the `case_utils.local_uuid` module may have made it unclear what function to call. `demo_uuid()` is effectively an internal function, and will raise a runtime error for users who don't set the intentionally-awkward environment variable to opt in to its behavior. This patch switches use to the intended "public" interface of the `case_utils.local_uuid` module. Signed-off-by: Alex Nelson <[email protected]>
Collaborator
|
May have been premature on this merge, does my modification bring #20 and #21 together and work for what you were intending? @ajnelson-nist I was having an issue with merge due to #21 over-writing most of #20 |
ajnelson-nist
commented
May 12, 2023
Member
Author
ajnelson-nist
left a comment
ajnelson-nist
left a comment
There was a problem hiding this comment.
The intended change survived the merging. Thanks!
ajnelson-nist
added a commit
to casework/CASE-Utilities-Python
that referenced
this pull request
May 12, 2023
I stumbled across this being a potential point of confusion in the Exifread mapping repository's PR 21. References: * casework/CASE-Implementation-PyPI-Exifread#21 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Utilities-Python
that referenced
this pull request
May 12, 2023
I stumbled across this being a potential point of confusion in the Exifread mapping repository's PR 21. References: * casework/CASE-Implementation-PyPI-Exifread#21 Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.