Re-flow case_prov_dot #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch revises `case_prov_dot` to make use of updates in code review practice and upstream typing support since the script was originally written. The original version of `case_prov_dot` relied on many conversions of RDFLib types to strings. This induced some reinvention of logical organization of concepts into IRI strings vs. quickly-instantiated and -discarded `rdflib.URIRef` objects. Some usage of `URIRef`s as strings was covered by `URIRef`s being implemented in RDFLib as subclasses of string. As work progressed on adding TIME concept support (see PR 54), it became unnecessarily burdensome to handle some work with managing untyped strings under specialized consideration, versus constructing sets of `rdflib.URIRef`s to designate nodes. Managing potential blank nodes also became a challenge with casts to strings. This patch revises the base work in `case_prov_dot` to be oriented on analyzing sets of `rdflib.term.IdentifiedNode`s (encompassing `URIRef`s and `BNode`s). A roadmap/codemap is also added in inline documentation to describe sections of code behavior. Revision of the code flow also settled some design issues that were previously unnecessarily isolating the various chains from one another, especially where some chains needed to be handled as a mutual union, and another needed to be handled as an intersection, when various subsets of the provenance graph are requested. So this patch also adds the various pairs of chains as demonstrations under the Urgent Evidence example. A follow-on patch will regenerate Make-managed files. References: * #54 Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly code motion, code documentation, and improved static type review on
case_prov_dot. It will be merged on passing CI.Some of the motivation comes from preparations for the OWL-Time updates in #54. Full documentation of the patch series is in the first patch's log message.
There is now an improvement in functionality, where behaviors of the multiple "subsetting" flags have been reviewed and now work with one another, instead of being isolated from one another. The Urgent Evidence narrative figures have been updated to demonstrate the flags' interactions.