-
-
Couldn't load subscription status.
- Fork 15
fix: allow prefer-takeuntil and prefer-composition rules to support p… #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: allow prefer-takeuntil and prefer-composition rules to support p… #12
Conversation
3083f05 to
44cc98d
Compare
|
You could open a PR under fork https://github.com/JasonWeinzierl/eslint-plugin-rxjs-angular-x . |
Hey @JasonWeinzierl, that's a sure thing! Are you working with @ktrz and the ClickUp folks? I know they were also discussing creating a fork. |
Oop I haven't heard from them, thank you! I've been following discussions here: angular-eslint/angular-eslint#2094 and here: ReactiveX/rxjs#7492 , as well as issues on this repo itself. Is there anywhere else discussions are happening? |
It is probably in closed conversations for now. But I'm happy to contribute to your work while the ecosystem aligns. |
The Problem:
Fixes: #11
Previous Behavior
Javascript private variables like
#subscriptionwere not supported forprefer-takeuntilandprefer-compositionrulesCurrent Behavior
It allows for the
prefer-takeuntilandprefer-compositionrules to use Javascript private variables.