chore: Convert utils to Kotlin #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule | ||
| import com.intellij.util.xmlb.Converter | ||
|
|
||
| abstract class BaseConverter<T> protected constructor(private val typeReference: TypeReference<T>) : Converter<T?>() { |
There was a problem hiding this comment.
Can we remove the nullable operators?
|
|
||
| import com.fasterxml.jackson.core.type.TypeReference | ||
|
|
||
| class MapConverter : BaseConverter<Map<String?, Any?>?>(object : TypeReference<Map<String?, Any?>?>() {}) |
There was a problem hiding this comment.
Removed them in both converters
reneleonhardt
force-pushed
the
convert-to-kotlin
branch
from
9f8ec7a to
225e4b1
Compare
carlrobertoh
pushed a commit
that referenced
this pull request
Apr 21, 2024
* chore: Convert utils to Kotlin * Remove nullable operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DownloadingUtil has already been converted in DBRX #462