Skip to content

fix for aws lambda http gateway events sometimes having rawQueryString = null #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2023
Merged

fix for aws lambda http gateway events sometimes having rawQueryString = null #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733fdbb
various debug things i wanna keep record of
cardenaso11 May 19, 2023
c19f180
cleanup debug stuff. see parent commit for debug stuff
cardenaso11 May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ impl LambdaHttpEvent<'_> {
match self {
Self::ApiGatewayHttpV2(event) => {
let path = encode_path_query(&event.raw_path);
let query = &event.raw_query_string as &str;
let query_string = event.raw_query_string.clone().unwrap_or("".to_string());
let query = query_string.as_str();

if query.is_empty() {
// No query string
path.into_owned()
Expand Down Expand Up @@ -242,7 +244,7 @@ pub(crate) struct ApiGatewayHttpV2Event<'a> {
#[allow(dead_code)]
version: String,
raw_path: String,
raw_query_string: String,
raw_query_string: Option<String>,
cookies: Option<Vec<String>>,
headers: HashMap<String, String>,
//#[serde(borrow)]
Expand Down
5 changes: 3 additions & 2 deletions src/rocket05.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ use std::sync::Arc;
pub async fn launch_rocket_on_lambda<P: rocket::Phase>(
r: rocket::Rocket<P>,
) -> Result<(), LambdaError> {
lambda_runtime::run(RocketHandler(Arc::new(
let handler: RocketHandler = RocketHandler(Arc::new(
rocket::local::asynchronous::Client::untracked(r).await?,
)))
));
lambda_runtime::run(handler)
.await?;

Ok(())
Expand Down