Sourcery Starbot ⭐ refactored capdevc/jupyterlab_autoversion #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Sep 28, 2022
Comment on lines
-34
to
36
| print( | ||
| "Installing jupyterlab_autoversion handler on path %s" | ||
| % url_path_join(base_url, "autoversion") | ||
| f'Installing jupyterlab_autoversion handler on path {url_path_join(base_url, "autoversion")}' | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function load_jupyter_server_extension refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
| for line in fp: | ||
| if ".autoversion" in line: | ||
| add = False | ||
| add = all(".autoversion" not in line for line in fp) |
There was a problem hiding this comment.
Function initialize refactored with the following changes:
- Use any() instead of for loop (
use-any) - Invert any/all to simplify comparisons (
invert-any-all)
| return | ||
|
|
||
| if not id and path: | ||
| if not id: |
There was a problem hiding this comment.
Function GitGetHandler.get refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
| return | ||
|
|
||
| if not id and path: | ||
| if not id: |
There was a problem hiding this comment.
Function GitRestoreHandler.get refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if) - Replace if statement with if expression (
assign-if-exp)
|
|
||
| m.web_app.settings = {} | ||
| m.web_app.settings["base_url"] = "/test" | ||
| m.web_app.settings = {"base_url": "/test"} |
There was a problem hiding this comment.
Function TestExtension.test_load_jupyter_server_extension refactored with the following changes:
- Merge dictionary assignment with declaration (
merge-dict-assign)
| return "" | ||
| else: | ||
| return 0 | ||
| return "" if name == "path" else 0 |
There was a problem hiding this comment.
Function TestExtension.test_git_restore refactored with the following changes:
- Replace if statement with if expression [×3] (
assign-if-exp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: