New Copy & Run button styles implementation #568
Conversation
phillipskevin
left a comment
phillipskevin
left a comment
There was a problem hiding this comment.
I think this works fine (other than the one small comment). I don't know a ton about this code though.
static/prism.less
Outdated
| top: 0 !important; | ||
| right: 0 !important; | ||
| border-left: 1px #dfdfdf solid; | ||
| border-bottom: 1px #dfdfdf solid; |
There was a problem hiding this comment.
Can you fix this indenting?
chasenlehara
left a comment
chasenlehara
left a comment
There was a problem hiding this comment.
This doesn’t look quite right (buttons over the expand bar):
I don’t see the Run button integrated into the toolbar. Should that be in this PR?
static/prism.less
Outdated
| > .toolbar { | ||
| line-height: 0; | ||
| top: 0 !important; | ||
| right: 0 !important; |
There was a problem hiding this comment.
Are the !important necessary? If yes right now, can we use a more specific selector to override the other styles, or are there other styles that should be removed?
static/prism.less
Outdated
| color: #858585 !important; | ||
| padding: .35em 2.25em !important; | ||
| box-shadow: none !important; | ||
| border-radius: 0 !important; |
There was a problem hiding this comment.
Same thing for the !important in the rest of this file. We should avoid them if at all possible.
What is not right, the style or Run button is missed?
@chasenlehara did you update bit-docs-html-canjs/make-example.js Line 31 in 5543af3 |
|
@chasenlehara I updated the styles, for notes, buttons toolbar is a sibling to the collapsible bar parent. |
Fixes #561
Depends on bit-docs/bit-docs-html-codepen-link#14