Updated type size, color and margin #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamiemccue
commented
Jul 18, 2019
jamiemccue
commented
- make h3-h6 headings larger and gray
- Reduce margin-bottom .on-this-page-table
- Increase margin below codepen
chasenlehara
approved these changes
Jul 22, 2019
Member
chasenlehara
left a comment
chasenlehara
left a comment
There was a problem hiding this comment.
These changes are ok. I don’t think we make much use of h5 or h6, but I would expect us to want them to have different styles than h4. I’m not sure if font-weight: @font-weight-heading was intentionally left off of the h4 styles, but them having more weight and being darker makes the hierarchy confusing to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.