Skip to content

Conversation

@chasenlehara
Copy link
Member

@chasenlehara chasenlehara commented Apr 23, 2019

Chasen/dev tasks:

  • Add the TOC component
  • Scroll to the top of the TOC sidebar when a new page is loaded
  • Polyfill for Edge

Ryan tasks:

  • Style it (probably bring in these styles)
  • Make the bullets (and lines?) smaller
  • Bottom padding in TOC sidebar
  • Make a mockup of what connecting the first dots would look like [get signoff from Justin]

Need to figure out:

  • Do we want to connect the dots?

Will close canjs/canjs#4744

Right now it’s removed and re-added to the DOM every time a new page is loaded. Waiting for bit-docs/bit-docs-html-toc#26 to be implemented.

Part of canjs/canjs#4744
@justinbmeyer
Copy link
Contributor

justinbmeyer commented May 16, 2019

I don't think we need to polyfill for browsers that don't support it. I wrote TOC in such a way it's a no-op in browsers that don't support what is needed.

I thought Edge supports some limited custom elements. We could probably just modify to use that: https://github.com/bit-docs/bit-docs-html-toc/blob/master/safe-custom-element.js ... specifically do something other than:

customElements.define(tag, Element);

@ryangwilson
Copy link

ryangwilson commented May 16, 2019

Mocked-up angled into nest concept – @justinbmeyer please review when you have time
dots all gray

dots with blue

(imo I don't like it)

@ryangwilson
Copy link

Looking good on all major/current desktop browsers except Edge. Working on a fix for Edge (this is a layout issue, not related to the TOC/polyfill menu not showing up)

@ryangwilson
Copy link

Edge fix layout screenshots
Screen Shot 2019-05-16 at 12 14 53 PM
Screen Shot 2019-05-16 at 12 14 45 PM
Screen Shot 2019-05-16 at 12 14 36 PM
Screen Shot 2019-05-16 at 12 14 29 PM

@ryangwilson
Copy link

The change in scale for the SVG icons for the TOC sidebar work well on the community page as well
Screen Shot 2019-05-16 at 12 29 22 PM

Question for @ – For the social links should we change the Community page order to match the TOC sidebar order? Not necessary for this PR, but something to consider.

@ryangwilson
Copy link

Angles added downwards in the nesting chain – tested on MacOS Chrome, FF, and Safari, and PC Chrome and FF. Edge doesn't work bc of known issue where TOC is not appearing
Screen Shot 2019-05-16 at 2 29 35 PM

@ryangwilson
Copy link

@chasenlehara we are having failing tests that need to be resolved (looks like master has the same issue as well). @justinbmeyer asked to put this on hold until you return. Aside from that, this branch should be ready.

Chasen Le Hara added 3 commits May 22, 2019 09:21
@chasenlehara chasenlehara changed the title WIP: Move the in-page nav into the main content Move the in-page nav into the main content May 29, 2019
@chasenlehara chasenlehara marked this pull request as ready for review May 29, 2019 18:13
@chasenlehara chasenlehara merged commit fc7e128 into master May 30, 2019
@chasenlehara chasenlehara deleted the 4744-toc branch May 30, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the in-page nav into the main content

4 participants