-
Notifications
You must be signed in to change notification settings - Fork 0
Move the in-page nav into the main content #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Right now it’s removed and re-added to the DOM every time a new page is loaded. Waiting for bit-docs/bit-docs-html-toc#26 to be implemented. Part of canjs/canjs#4744
|
I don't think we need to polyfill for browsers that don't support it. I wrote TOC in such a way it's a no-op in browsers that don't support what is needed. I thought Edge supports some limited custom elements. We could probably just modify to use that: https://github.com/bit-docs/bit-docs-html-toc/blob/master/safe-custom-element.js ... specifically do something other than: |
|
Mocked-up angled into nest concept – @justinbmeyer please review when you have time (imo I don't like it) |
|
Looking good on all major/current desktop browsers except Edge. Working on a fix for Edge (this is a layout issue, not related to the TOC/polyfill menu not showing up) |
… that the two headers don't stack before the toc loads
|
@chasenlehara we are having failing tests that need to be resolved (looks like master has the same issue as well). @justinbmeyer asked to put this on hold until you return. Aside from that, this branch should be ready. |
This reverts commit 117bc3c.
This makes it so the last highlighted item in the TOC is always visible.








Chasen/dev tasks:
Ryan tasks:
Need to figure out:
Will close canjs/canjs#4744