[WIP] CanJS Header reformat I4744 #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent This is unfortunately a hack for now. The homepage and community page are hard-coded to not show the sidebar.
- Dismiss the search results popover when a result is clicked - Dismiss the search results when clicking outside them - Show the search results if the search field is given focus while it has text in it - Make sure the search results don’t overlap with the survey ad - Remove the brand’s unnecessary white background that was visible in Safari - Fix the background of the search results in Safari - Tone down the drop shadow on the search results
They broke after updating the docMap.
Node 12 fails with the error “ReferenceError: primordials is not defined”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress
I'm passing this off to @chasenlehara to:
Chasen tasks:
#leftat tablet/desktop sizes on pages that don’t have sidebar content (homepage & community)Ryan tasks:
class="current"is hard coded innav-links.mustacheatm