Fix issue with clicking docs in the sidebar #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user clicks on the docs for a package within the Core collection, the purpose group that it’s in (e.g. Observables) shouldn’t expand automatically. This fixes an issue where sections were expanding automatically when they shouldn’t, which fixed the issue with docs pages not loading correctly. Fixes canjs/canjs#4075
Contributor
|
@chasenlehara can you explain why these changed fixed the bug? |
Member
Author
|
Once I saw the bug that this PR fixes, I didn’t continue investigating why this click handler wasn’t being called to update the page, so I don’t have an explanation for why fixing this fixed the bug you reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user clicks on the docs for a package within the Core collection, the purpose group that it’s in (e.g. Observables) shouldn’t expand automatically.
This fixes an issue where sections were expanding automatically when they shouldn’t, which fixed the issue with docs pages not loading correctly.
Fixes canjs/canjs#4075
Gif of it working correctly now:
