Fix navigating to and from URLs with hashes #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you clicked on a link to a hash section and then clicked another link to a hash section, the second click wouldn’t work. This is fixed by correctly determining the hash you’re navigating to and from. Additionally, this fixes an issue in Firefox where the “On this page” navigation wouldn’t be updated with the correct title, and an issue in Chrome which would cause the navigation to be hidden when using the browser’s back button. Fixes #420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you clicked on a link to a hash section and then clicked another link to a hash section, the second click wouldn’t work.
This is fixed by correctly determining the hash you’re navigating to and from. Additionally, this fixes an issue in Firefox where the “On this page” navigation wouldn’t be updated with the correct title, and an issue in Chrome which would cause the navigation to be hidden when using the browser’s back button.
Fixes #420