Fix critical issues in IE 11 #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don’t support IE 10 and below.
IE 11 doesn’t require any -ms- prefixed styles for flexbox to work.
…r is loaded in IE 11
IE 11 doesn’t include the hostname or protocol on links with relative URLs, so this forces the URL to be absolute when a link is clicked.
It takes the buttons script an incredibly long time to execute on IE 11 (upwards of 30 seconds), so I’m “progressively degrading” the experience for IE 11 and not upgrading the star links to buttons. Additionally, the npm install command and buttons weren’t being shown because `display: unset` is not supported in IE, so that’s fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the most critical issues in IE 11:
Current CanJS.com:
After updates (images are broken because the screenshot’s from this repo):
Closes canjs/canjs#3619