Added star count to button in page title #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
reviewed
Jul 5, 2017
templates/title.mustache
Outdated
| </li> | ||
| <li> | ||
| <a class="github-button nav-social" href="https://github.com/canjs/{{repoName src.path}}">Star</a> | ||
| <a class="github-button nav-social" href="https://github.com/canjs/{{repoName src.path}}" data-count-href="/canjs/canjs/stargazers" data-show-count="true">Star</a> |
Member
There was a problem hiding this comment.
Does data-count-href do anything? If so, it should be for the individual repo, not the main CanJS repo.
Contributor
Author
There was a problem hiding this comment.
Seems to be a deprecated option. I've removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
