Move search into a web worker #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes all of the Lunr code and moves it to a web worker, so the indexing and searching process doesn’t block the main thread. This is a WIP because the way the web worker is loaded is a terrible hack.
Contributor
|
@chasenlehara Matthew said the proper way to setup the build file for the web worker is to just have multiple calls to stealTools in the same file, one for each output file. He also noted that we can't use an object for the stealTools |
chasenlehara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes all of the Lunr code and moves it to a web worker, so the indexing and searching process doesn’t block the main thread. This also adds a loading indicator when a search is being performed, which isn’t visible if the main thread is locked, hence the need for using a web worker.
This is a WIP because:
Before:
After:
