Fixed description link paths #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This doesn’t seem to be working for me: |
Contributor
Author
|
@chasenlehara my bad! I clearly didn't test that good enough. Updated the PR 😄 |
chasenlehara
approved these changes
Jun 29, 2017
static/search.js
Outdated
| var a = $a[0]; | ||
| var isLocal = a.hostname === location.hostname; | ||
| var isRelative = a.getAttribute('href').indexOf(location.hostname) === -1; | ||
| if(a.hostname !== location.hostname || a.protocol !== location.protocol){ |
Member
There was a problem hiding this comment.
a.hostname !== location.hostname could be !isLocal
| $a.attr('target', '_blank'); | ||
| } | ||
| if(isLocal && isRelative){ | ||
| var prefix = parentHref.substr(0, parentHref.lastIndexOf('/')); |
Member
There was a problem hiding this comment.
Comments on lines like this would make the code easier to read.
|
|
||
| if(this.url.substr(-1) === "/"){ | ||
| if(url.substr(-1) === "/"){ | ||
| return this.url; |
Contributor
Author
There was a problem hiding this comment.
static/search.js
Outdated
| var $html = $('<div>').html(html); | ||
| $html.find('a').each(function(){ | ||
| var $a = $(this); | ||
| var a = $a[0]; |
Member
There was a problem hiding this comment.
Going through this dance to convert the object to be jQuery-wrapped and then to unwrap it seems odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.