Cleanup styles for external resources and add local images #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
requested changes
Jun 14, 2017
Member
chasenlehara
left a comment
chasenlehara
left a comment
There was a problem hiding this comment.
Please vertically align the icons and the text so the text sits in the middle of the height of the icons.
static/content.less
Outdated
| .body{ | ||
| margin: @gutter*2; | ||
| } | ||
| ul.community-list { |
Member
There was a problem hiding this comment.
I’m hoping we’ll reuse this same pattern (icons next to list items), so let’s call it something like icon-list (or something better… naming is hard!).
Contributor
Author
|
@chasenlehara I've updated the PR: |
chasenlehara
approved these changes
Jun 14, 2017
Member
chasenlehara
left a comment
chasenlehara
left a comment
There was a problem hiding this comment.
It’d be nice to have a little more space between the icons and text, but otherwise this looks great!
imaustink
force-pushed
the
added-community-page-resources
branch
from
f3ce8f4 to
96ec020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to canjs/canjs#3223