Update lunr #320
Merged
Update lunr #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
imaustink
commented
Jun 13, 2017
imaustink
commented
- Updated Lunr to 2.1.0
- Updated use of the wildcard
- Removed dead code
- Fallback to name if no title
- Updated use of wildcard.\n- Removed dead code\n- Fallback to name if no title
chasenlehara
approved these changes
Jun 13, 2017
| } else { | ||
| // add “can-”, look for an exact match in the title field, and apply a positive boost | ||
| q.term('can-' + searchTerm, { usePipeline: false, fields: ['title'], boost: 12 }); | ||
| q.term('can-' + searchTerm, { usePipeline: false, boost: 12 }); |
Member
There was a problem hiding this comment.
I removed the fields property when we were testing things, but didn’t mean for this change to be committed. If it’s working then ok, but it might be useful to add back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.