Improve the search result ordering #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if we made changes to the indexing code, the cached version of the Lunr index (from local storage) would still be used. This commit adds a version number near our indexing code that should be incremented whenever we make changes to how Lunr indexes our content.
chasenlehara
commented
Jun 2, 2017
| "styles": "rm -rf node_modules/bit-docs-generate-html/site/static && node make-example.js -f", | ||
| "test": "npm run testee", | ||
| "styles": "rm -rf node_modules/bit-docs-generate-html/site/static && npm start", | ||
| "test": "npm start && npm run testee", |
Member
Author
There was a problem hiding this comment.
We need to generate the site before running the tests so it always works.
chasenlehara
commented
Jun 2, 2017
| var searchIndexVersionKey = this.formatLocalStorageKey(this.searchIndexVersionLocalStorageKey); | ||
| var index = this.getLocalStorageItem(searchIndexKey); | ||
| var indexVersion = this.getLocalStorageItem(searchIndexVersionKey); | ||
| var currentIndexVersion = 1;// Bump this whenever the index code is changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites how we query the Lunr index to get search results. I’ve added tests for a few scenarios—if you test search and find that the results aren’t great for a specific term, I can add a new test case for it and fix the results.
Fixes #290