Updates to On This Page CSS #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactoring the menu so the <a> has the padding and <li> is just the wrapper - Separating the / as an individual li - Reversing out the background when selected - Removing the caret triangle altogether
Contributor
|
Do we have rounded elsewhere? Not sure it fits with brutalist aethstetic. |
Contributor
Author
|
Removed border radius |
- Only show the pointer cursor when hovering over a link/dropdown - Show the white background behind the anchor anytime the dropdown is open Related to #197
chasenlehara
approved these changes
May 31, 2017
Member
chasenlehara
left a comment
chasenlehara
left a comment
There was a problem hiding this comment.
@imaustink Could you look this over before merging please?
imaustink
requested changes
May 31, 2017
Contributor
imaustink
left a comment
imaustink
left a comment
There was a problem hiding this comment.
Looks like there is an issue with pages that don't have a table of contents.
Member
|
@imaustink Would you mind fixing that issue please? |
imaustink
approved these changes
Jun 1, 2017
imaustink
force-pushed
the
bit-docs-197-nav-css
branch
from
b3b6904 to
56c866a
Compare
Contributor
|
@chasenlehara I've updated the PR to address that issue.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrapper