Added responsive styles for search box #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I noticed the
notice how it's not a problem there. |
chasenlehara
requested changes
May 25, 2017
Member
chasenlehara
left a comment
chasenlehara
left a comment
There was a problem hiding this comment.
We should probably turn off autocorrect and spellcheck from the search field so users don’t get frustrating suggestions for things like “pushstate”.
static/search.less
Outdated
| left: 0; | ||
| background-color: hsla(32, 96%, 49%, 0.61); | ||
| } | ||
| } |
Contributor
Author
|
Updated the PR 😃 |
Contributor
Author
|
@justinbmeyer good catch. I am sure it's possible, probably easy. For now, I opened another issue #264 |
Member
|
@imaustink In your screenshot, it looks like the results are over-escaped too. We have to fix those issues before we deploy search, so I’ve brought that issue you opened to the top of the backlog. |
chasenlehara
approved these changes
May 25, 2017
chasenlehara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop:
Mobile:
