Enhancement: Add more block-comment related tests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and jsdoc-like @doctags-comments.
|
More tests are always welcome, and it looks like they're passing, that's awesome |
caitp
pushed a commit
that referenced
this pull request
Sep 17, 2013
Enhancement: Add more block-comment related tests
|
Thanks for merging and this pull-request anyway … 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My assumption that the final trailing space is not required for single-line block-comments was wrong. Therefore I didn't tweak anything in
nodes.js. 😳Nevertheless, I'd still like to add some additional tests, one for single-line block-comments ensuring that the rendering does not change and three more tests related to jsdoc-like
@doctag-comments. I also added additional comments to these tests, to emphasize that this pull-request is not yet the final solution. I know this caused lot's of headache for many people and this pull-request will certainly enhance the situation. But it does not solve the issues related to the comment placement, if several variables to comment are involved. I assume this is also the reason why this well known issue is not yet resolved.Finally I'll also update my comment, to clarify that my “needless additional space in single-line block-comments” assumption is wrong.
Good job 😏