-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update everything to Android 3.2 canary 4 #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tux-mind if you take a look and it works, can you create a new build? Are there x86 libraries btw? Cheers |
While waiting for cSploit 2.0 to come online, here's a quick refresh: * target API/sdk 27, support as far back as 14 (from 9) * update libraries and use new "implementation" build.gradle syntax * Update Java to 1.8 * Update to gradle 4.5.1 from 2.9 * Update android gradle plugin from 1.5.0 to 3.2.0-a3 * Use the google dependency repository * simplify build.gradle date stamp calculation * update ACRA (even though target end point @ iriscouch went offline). This is not really tested past the "send info" dialog (no point) * Support multi-window on chromebook. * Add Notification Channel as required by Oreo (Android 8) * Add very simple runtime permissions request * Minor changes to use .apply() instead of .commit() * Similar minor fix to use Locale with string formatting. * Minor removal of dialog theme defining itself * Fix bug in SettingsFragment where super.onViewCreated() not called * Minor fix to preferences compat xml file Th-that's all, folks!
|
Sure enough, mere moments after I pushed this, alpha 3 came out. So I updated this PR to the latest. |
|
I could but it wouldn't be signed properly (I don't have the key for the releases). I may just update this PR to the latest alpha and push to the /develop branch which would hopefully get picked up by the build bot at http://www.csploit.org/downloads/ -- is @xaitax around, per chance? I'm guessing some term acceptance would be needed. |
|
The new nightly is built. Please test. 👍 |
pahapoika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crashes on Lineageos 15.1 (8.1)
Logcat: https://pastebin.com/617YaHG2
|
@fat-tire nightly doesn't work on 8.1 after this commit. Stable works fine. Please consider undoing |
|
@pahapoika Stay on stable then. It's called "nightly" for a reason. ;) |
|
@xaitax yeah I will, but the commits breaks compatibility with 8.0(.1) completely, so I think it should be rolled back |
|
Nope. It's an ongoing progress till it's stable for the nightly. This is a normal development progress. |
|
@xaitax just noticed that it was pushed to develop branch instead of master and since the 2.0 will have completely different branch it's fine |
|
I just don't like if shit breaks because of untested commit (even if its to develop branch) |
|
I don't have an arm device w/8.1. The emulators only have arm versions available up to API 25, where it works with the permissions as requested. This is why I waited 2 weeks before committing. Would waiting three weeks rather than two have been better for your schedule? Anyway, I'll respond more thoroughly in the issue you created #941 |
While waiting for cSploit 2.0 to come online, I got bored. So for anyone still using it, here's a quick refresh.
Note that I have not tested on a physical Oreo device as I don't have one and the oreo emulator is x86 only. I do have commit rights, but wanted to let people try it out before I add to
develormasteror wherever. Cheers!This is not really tested past the "send info" dialog (no point)
Th-that's all, folks!