Compiler: simplify argument parsing, add -Dxxx for features #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I consider the huge amount of arguments to gcc an anti-pattern. I would prefer to put those things in config files like the recipe. Adding yet another arguments to duplicate gcc does not feel right. The goal is not to be like gcc... but better ;) |
chqrlie
force-pushed
the
features
branch
7 times, most recently
from
cda6d42 to
04ca49d
Compare
chqrlie
force-pushed
the
features
branch
5 times, most recently
from
0e38a59 to
1c03805
Compare
chqrlie
force-pushed
the
features
branch
3 times, most recently
from
f96f185 to
8639c28
Compare
chqrlie
force-pushed
the
features
branch
2 times, most recently
from
3da1690 to
484fa6f
Compare
chqrlie
force-pushed
the
features
branch
6 times, most recently
from
7145eda to
6ddeffb
Compare
* add `unknown_option()` to factor error handling * simplify option parsing, add `argarg` for options with an arguments * add `-DFeature` to define features from the command line * simplify `Compiler.addFeature()`: feature values are not supported yet and could be specified as `Feature=value` later * simplify Makefile for bootstrap phases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unknown_option()to factor error handlingargargfor options with an arguments-DFeatureto define features from the command lineCompiler.addFeature(): feature values are not supported yet and could be specified asFeature=valuelater