Skip to content

fix: linux compile #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix: linux compile #5

merged 1 commit into from
Feb 23, 2022

Conversation

@yamauta77
Copy link

@yamauta77 yamauta77 commented Sep 21, 2021 •
edited
Loading

reproduce step on Ubuntu:

make

error message:

quickjs.c:23812:13: error: invalid operands to binary != (have ‘JSValue’ {aka ‘struct JSValue’} and ‘JSValue’ {aka ‘struct JSValue’})
23812 |     if (tag != JS_UNINITIALIZED) {

Plz review it.
Thanks.

@srh
Copy link

srh commented Feb 22, 2022

I also encountered this issue on Linux when integrating QuickJS into RethinkDB. And this PR has fixed it.

@c-smile c-smile merged commit a2ce903 into c-smile:master Feb 23, 2022
@yamauta77 yamauta77 deleted the fix_linux_compile branch April 2, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yamauta77 @srh @c-smile