Skip to content

Notify spies only after validate the data #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Notify spies only after validate the data #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/rpc/RpcBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,6 @@ void RpcBase::processReceivedData(const void* data, size_t size)
{
// Decode received data
std::string received_data(reinterpret_cast<const char*>(data), size);
for (ISpy* spy : m_spies)
{
spy->rcpMessageReceived(received_data);
}

// RPC frame must be a JSON array
bool valid = false;
Expand All @@ -315,6 +311,10 @@ void RpcBase::processReceivedData(const void* data, size_t size)
}
if (valid && rpc_frame.IsArray() && (rpc_frame.Size() >= 3))
{
for (ISpy* spy : m_spies)
{
spy->rcpMessageReceived(received_data);
}
// Extract message type
const rapidjson::Value& msg_type_value = rpc_frame[0];
if (msg_type_value.IsUint())
Expand Down