Minimal optimization for cap-async-std. #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/async
branch
22 times, most recently
from
368bef5 to
e099878
Compare
|
This PR depends on async-rs/async-std#937 making it to a published async-std. |
sunfishcode
force-pushed
the
main
branch
2 times, most recently
from
6853fdf to
21a5954
Compare
|
Two functions to revisit here: |
sunfishcode
force-pushed
the
main
branch
4 times, most recently
from
7f9c0a9 to
16a65b1
Compare
sunfishcode
force-pushed
the
sunfishcode/async
branch
6 times, most recently
from
0802a1f to
70efc10
Compare
sunfishcode
force-pushed
the
sunfishcode/async
branch
from
70efc10 to
d3346a3
Compare
sunfishcode
force-pushed
the
sunfishcode/async
branch
4 times, most recently
from
69c8678 to
492748c
Compare
sunfishcode
force-pushed
the
main
branch
3 times, most recently
from
fc0ebc2 to
dd73714
Compare
sunfishcode
force-pushed
the
sunfishcode/async
branch
3 times, most recently
from
5eb0df5 to
5ec1285
Compare
sunfishcode
force-pushed
the
main
branch
4 times, most recently
from
4a03710 to
6e53944
Compare
Use `spawn_blocking` to run important blocking tests off the main thread.
sunfishcode
force-pushed
the
sunfishcode/async
branch
from
5ec1285 to
df559d9
Compare
|
async-std 1.10 is now released, which includes async-rs/async-std#937, so this can land now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
spawn_blockingto run important blocking tests off the mainthread.