A more Swift friendly route registration #136
Conversation
wessmith
force-pushed
the
wes/introduce_swiftier_registration
branch
from
42184d7 to
ccc1d0b
Compare
|
💯 |
|
|
||
|
|
||
| /** | ||
| A Swift friendle version of -registerBlock:forRoute: |
README.md
Outdated
|
|
||
| Swift | ||
| ````swift | ||
| self.router.registerRoute("/log/:message") { link in |
There was a problem hiding this comment.
This would ideally be changed to come through as register(route:)
There was a problem hiding this comment.
It doesn't because there's already a method called -registerBlock:forRoute: which gets the shorthand register:. Changing the order in the header would do it but also breaks the current API. Best we can do is define it as register:routeHandlerBlock:
| // Register a block to a route (matches dpl:///product/93598) | ||
| self.router.registerRoute("/product/:sku") { link in | ||
|
|
||
| if let rootViewController = application.keyWindow?.rootViewController as? UINavigationController { |
There was a problem hiding this comment.
There should use guard let and you might want to use optional chaining so you don’t need multiple lets
|
|
||
| // Register a class to a route using the explicit registration call | ||
| self.router.registerRoute("/log/:message") { link in | ||
| if let link = link { |
There was a problem hiding this comment.
Can we make the link passed to the block non-optional?
There was a problem hiding this comment.
Yes. That's the plan but at the moment we don't have any nullability annotations and adding them technically breaks the API. I'd rather do this in 2.0.
The focus of this change is to disable subscript registration in Swift because the blocks were ignored internally and never called. It looks like you can't even use that API in Swift 4.
wessmith
force-pushed
the
wes/introduce_swiftier_registration
branch
from
ccc1d0b to
1987978
Compare
wessmith
force-pushed
the
wes/introduce_swiftier_registration
branch
from
1987978 to
0a4d77a
Compare
The focus of this change is to disable subscript registration in Swift because the blocks were ignored internally and never called.