Skip to content

[email protected] #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 13, 2025
Merged

[email protected] #26

merged 8 commits into from
Jul 13, 2025

Conversation

StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson commented Jul 13, 2025

  • add support for modules: None input
  • reduced default installed modules to only il2cpp per platform

- add support for `modules: None` input
@Copilot Copilot AI review requested due to automatic review settings July 13, 2025 15:21
@StephenHodgson StephenHodgson requested a review from a team as a code owner July 13, 2025 15:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Add support for a modules: None input to allow skipping module installation and update related configuration.

  • Guard removePath to accept undefined or non-existent paths, avoiding errors during cleanup.
  • Refactor ValidateInputs to skip 'none' modules, adjust default modules logic, and update the function signature.
  • Bump package version, switch examples and CI matrix to the singular unity-version key, and add modules: None test cases.

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/unity-hub.ts Updated removePath signature and added a guard around deletion.
src/inputs.ts Changed input validation to support modules: None and simplified defaults.
src/index.ts Added a null/undefined check before using installPath.
package.json Bumped action version to 1.1.1.
README.md Updated sample workflow to use unity-version.
.github/workflows/validate.yml Switched matrix key to unity-version and added modules: None cases.

@StephenHodgson StephenHodgson merged commit 912fe96 into main Jul 13, 2025
26 checks passed
@StephenHodgson StephenHodgson deleted the development branch July 13, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant