several documentation updates #94
Conversation
few code changes
|
@ClaudiaFrank, 👍 I assume this has been a tedious work. Thank you. |
|
@Yaron10 - finding the motivation to start is the issue mostly but once started it wasn't that painful but |
| size_t docLength = (size_t)callScintilla(SCI_GETLENGTH); | ||
| size_t realLength = length; | ||
| callScintilla(SCI_SETREADONLY, 0); | ||
| for (idx_t i = 0; i < length; ++i) |
There was a problem hiding this comment.
@ClaudiaFrank Why is this no longer needed?
There was a problem hiding this comment.
Because the complete text should be colored - no need for special treatments like
in writeerror function but to be honest, I don't see why this special treamtent is needed at all or
what the benefit is.
There was a problem hiding this comment.
Added with:
Revision: d725887
Author: Dave Brotherstone [email protected]
Date: 13.08.2010 00:00:27
Message:
Stripped the \r from console output
- console.run output now a bit nicer if commands output \r\n
Modified: PythonScript/src/ConsoleDialog.cpp
There was a problem hiding this comment.
but I don't see the necessity.
Example with console.write and print. Note, write mehtod does not, contrary to print,
add an eol automatically to the end of the text.
>>> console.write('hello\r')
hello
>>> console.write('hello\n')
hello
>>> console.write('hello\r\n')
hello
>>> print('hello\r')
hello
>>> print('hello\n')
hello
>>> print('hello\r\n')
hello
>>>
The different behavior of print is related to python as it is internally using \n only, that
is the reason why the 2nd and third are having an additional line - but I don't think that
this was the reason to introduce this logis at all.
Coult it be that scintilla from 2010 had problems with different EOLs?
I did a search on scintilla google groups but I haven't found one.
Today, clearly, it hasn't. I can reintroudce the code, I don't mind - Just not sure if it is needed anymore. What about keeping it for some time and if no one complains remove the logic from the
others as well?
As said, I don't mind, if I should keep it the same like the others I will do so.
There was a problem hiding this comment.
Seems to be ok, let's see if someone finds an issue with it
| //lint +e849 | ||
|
|
||
| /* ++Autogenerated ---------------------------------------------- */ | ||
| enum CaseInsensitiveBehaviour |
There was a problem hiding this comment.
@ClaudiaFrank Do you have an idea why this is sorted differently now? Is this expected?
There was a problem hiding this comment.
Yes, this is expected because the createwrapper script
loops over a dictionary, which contrary to lists, do not
keep the ordering of its items.
I compared the old and new results and both are the same.
fixes #91