Skip to content

Two fixes, but mainly cleanups of Python test scripts to appease linters #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2024
Merged

Two fixes, but mainly cleanups of Python test scripts to appease linters #364

merged 1 commit into from
Dec 28, 2024

Conversation

Ekopalypse
Copy link
Contributor

No description provided.

@chcg chcg merged commit b08c46e into bruderstein:master Dec 28, 2024
6 checks passed
@alankilborn
Copy link

What 2 things got fixed with this?
I suppose I could fish through the commit, but I don't really have a desire to when it should (IMO) be better described here.

IMO it would be better if real "fixes" were in one PR, and "cleanups" were in a separate PR.

@Ekopalypse
Copy link
Contributor Author

For the record, the fixes are:
renaming

  • misspelled var callbackCalled to globalCallbackCalled
    and
  • test_replace_literal_start_later_end_sooner_2 to test_replace_literal_start_later_end_sooner_3

@Ekopalypse Ekopalypse deleted the test_scripts_cleanup branch March 21, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ekopalypse @alankilborn @chcg