Adapt tests to sci420 #133
Conversation
|
Is there a problem with this one? |
| @@ -801,7 +804,7 @@ def test_scintillawrapper_colour_int_void_in_callback(self): | |||
| self.assertEqual(self.callbackCalled, True) | |||
|
|
|||
| def test_scintillawrapper_bool_int_void(self): | |||
| original = editor.getMarginSensitiveN(1) | |||
| _ = editor.getMarginSensitiveN(1) | |||
There was a problem hiding this comment.
Why did you change this? Is there any need for it or just because it is an unused value.
There was a problem hiding this comment.
Need, depends, this and the other change is basically to satisfy the python linter.
| @@ -2,7 +2,10 @@ | |||
| import unittest | |||
| import time | |||
|
|
|||
| from Npp import * | |||
| from Npp import ( | |||
There was a problem hiding this comment.
Why are the imports in braces?
What is the benefit to import just the necessary module parts for the tests?
There was a problem hiding this comment.
In this case, both are Linter issues.
|
@Ekopalypse Let's see how smart the git merge is. Just didn't merge because of some questions regarding the changes, but forgot to click submit for my review comments. |
Make tests run with scintilla 4.2.0