Skip to content

Updated the code for new state empty title issue in History.setTitle method. #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated the code for new state empty title issue in History.setTitle method. #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95827a4
updated the code for new state empty title issue.
Dec 7, 2017
ad02b23
updated title condition with empty,null and undefined.
Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/bundled-uncompressed/html4+html5/native.history.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2596,10 +2596,13 @@ if (typeof JSON !== 'object') {

// Apply
try {
document.getElementsByTagName('title')[0].innerHTML = title.replace('<','&lt;').replace('>','&gt;').replace(' & ',' &amp; ');
if(title) //Don't update the document title if newState title is empty/undefined.
document.getElementsByTagName('title')[0].innerHTML = title.replace('<','&lt;').replace('>','&gt;').replace(' & ',' &amp; ');
}
catch ( Exception ) { }
document.title = title;

if(title) //Don't update the document title if newState title is empty/undefined.
document.title = title;

// Chain
return History;
Expand Down
7 changes: 5 additions & 2 deletions scripts/bundled-uncompressed/html5/native.history.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,10 +1426,13 @@

// Apply
try {
document.getElementsByTagName('title')[0].innerHTML = title.replace('<','&lt;').replace('>','&gt;').replace(' & ',' &amp; ');
if(title) //Don't update the document title if newState title is empty/undefined.
document.getElementsByTagName('title')[0].innerHTML = title.replace('<','&lt;').replace('>','&gt;').replace(' & ',' &amp; ');
}
catch ( Exception ) { }
document.title = title;

if(title) //Don't update the document title if newState title is empty/undefined.
document.title = title;

// Chain
return History;
Expand Down