Skip to content

Fix Specs Array Case for Enforce_Settings MAC #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix Specs Array Case for Enforce_Settings MAC #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c460953
Fix Specs Array Case for Enforce_Settings MAC
hariharanbrowserstack Dec 11, 2023
e12b043
Fix UT
hariharanbrowserstack Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,7 +1327,7 @@ exports.setEnforceSettingsConfig = (bsConfig) => {
if(specConfigs && specConfigs.includes(',')) {
specConfigs = JSON.stringify(specConfigs.split(','));
}
let spec_pattern_args = 'specPattern="'+specConfigs+'"';
let spec_pattern_args = `specPattern=${specConfigs}`;
config_args = this.isUndefined(config_args) ? spec_pattern_args : config_args + ',' + spec_pattern_args;
}
if ( this.isNotUndefined(config_args) ) bsConfig["run_settings"]["config"] = config_args;
Expand Down
4 changes: 2 additions & 2 deletions test/unit/bin/helpers/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3107,7 +3107,7 @@ describe('utils', () => {
run_settings: { specs: 'somerandomspecs', cypressTestSuiteType: 'CYPRESS_V10_AND_ABOVE_TYPE' },
};
let args = {
config: 'video=false,videoUploadOnPasses=false,specPattern="somerandomspecs"'
config: 'video=false,videoUploadOnPasses=false,specPattern=somerandomspecs'
}
utils.setEnforceSettingsConfig(bsConfig);
expect(args.config).to.be.eql(bsConfig.run_settings.config);
Expand All @@ -3117,7 +3117,7 @@ describe('utils', () => {
run_settings: { specs: 'somerandomspecs1,somerandomspecs2', cypressTestSuiteType: 'CYPRESS_V10_AND_ABOVE_TYPE' },
};
let args = {
config: 'video=false,videoUploadOnPasses=false,specPattern="["somerandomspecs1","somerandomspecs2"]"'
config: 'video=false,videoUploadOnPasses=false,specPattern=["somerandomspecs1","somerandomspecs2"]'
}
utils.setEnforceSettingsConfig(bsConfig);
expect(args.config).to.be.eql(bsConfig.run_settings.config);
Expand Down